feat: add mock_file_check_guard() for scope-based cleanup#3
Closed
feat: add mock_file_check_guard() for scope-based cleanup#3
Conversation
_check() stored the file argument in $_last_call_for for -X _ caching. When the argument was a filehandle reference (not a string path), this prevented the filehandle from being garbage collected, keeping the underlying file descriptor open. This caused "spooky action-at-a-distance" bugs: e.g. a socketpair read hanging because a dup'd write-end filehandle was kept alive by the leaked reference, even after leaving scope. Fix: only cache string filenames in $_last_call_for, not references. Ref: cpan-authors/Test-MockFile#179 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ef-leak fix: prevent filehandle reference leak in stat override
Add CLAUDE.md with project guidance for Claude Code sessions. Exclude CLAUDE.md and local/ directory from Dist::Zilla GatherDir so they don't end up in the CPAN tarball.
Update actions/checkout and CI
Returns a guard object whose DESTROY calls unmock_file_check, enabling automatic mock cleanup on scope exit. Improves test isolation without changing the existing API. The guard also supports cancel() to keep the mock active beyond the scope, and handles double-destroy gracefully. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
need to resubmit to the parent repo |
Owner
|
@Koan-Bot squash |
Collaborator
Author
|
Rebased and recreated as cpan-authors#96, targeting main on the new upstream repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
mock_file_check_guard($check, \&sub)— likemock_file_checkbut returns a guard object that auto-unmocks on scope exit.Why
Tests using
mock_file_checkmust manually callunmock_file_checkin cleanup, which is error-prone — especially when tests die. The guard pattern ensures cleanup even on early exit, improving test isolation.How
Overload::FileCheck::Guardpackage with DESTROY-based cleanupcancel()method to opt out of auto-unmockevalin DESTROY to never propagate exceptionsTesting
t/guard.tcovering: basic scope cleanup, cancel, double-destroy, die-in-eval, dash-less check names, FALLBACK_TO_REAL_OP🤖 Generated with Claude Code